Incomplete Cleanup

Demonstrations

The following examples help to illustrate the nature of this weakness and describe methods or techniques which can be used to mitigate the risk.

Note that the examples here are by no means exhaustive and any given weakness may have many subtle varieties, each of which may require different detection methods or runtime controls.

Example One

Stream resources in a Java application should be released in a finally block, otherwise an exception thrown before the call to close() would result in an unreleased I/O resource. In the example below, the close() method is called in the try block (incorrect).

try {
  InputStream is = new FileInputStream(path);
  byte b[] = new byte[is.available()];
  is.read(b);
  is.close();
} catch (Throwable t) {
  log.error("Something bad happened: " + t.getMessage());
}

See Also